Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] prevent huge gas tx #462

Merged
merged 2 commits into from
Mar 18, 2021
Merged

[Hotfix] prevent huge gas tx #462

merged 2 commits into from
Mar 18, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 18, 2021

Summary of changes

  • The ante handler will block the tx with high gas than 30,000,000
  • Update ConsensusParams MaxGas = 30,000,000

Expected Update Time

// Expected time:
// MAINNET
// Tue Mar 30 2021 18:00:00 GMT+0900 (KST)
// Tue Mar 30 2021 09:00:00 GMT+0000 (UTC)
// Tue Mar 30 2021 01:00:00 GMT-0800 (PST)
//
// TEQUILA
// Tue Mar 25 2021 18:00:00 GMT+0900 (KST)
// Tue Mar 25 2021 09:00:00 GMT+0000 (UTC)
// Tue Mar 25 2021 01:00:00 GMT-0800 (PST)

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from hanjukim March 18, 2021 06:26
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #462 (ac15ae5) into master (4478905) will increase coverage by 0.15%.
The diff coverage is 75.00%.

❗ Current head ac15ae5 differs from pull request most recent head c1651bc. Consider uploading reports for the commit c1651bc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   67.21%   67.36%   +0.15%     
==========================================
  Files         119      119              
  Lines        5124     5127       +3     
==========================================
+ Hits         3444     3454      +10     
+ Misses       1460     1452       -8     
- Partials      220      221       +1     
Impacted Files Coverage Δ
x/auth/ante/spamming_prevention.go 84.61% <75.00%> (+74.61%) ⬆️

@hanjukim hanjukim added the enhancement New feature or request label Mar 18, 2021
@yun-yeo yun-yeo merged commit c066211 into master Mar 18, 2021
@yun-yeo yun-yeo deleted the feature/transaction-hard-cap branch March 18, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants