Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] WASM logging whitelist #413

Merged
merged 12 commits into from
Oct 19, 2020
Merged

[Feature] WASM logging whitelist #413

merged 12 commits into from
Oct 19, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Oct 6, 2020

Summary of changes

Now the contracts can emit bunch of logs without any cost. To restrict those resource waste, this update will allow a node operation to set whitelist addresses for from_contract event logging.

Automatic Whitelisting

The node software will automatically adds newly instantiated contract address to the list if the instantiator's address is in the whitelist. As a result, all contracts address including contract initiated by contracts will also automatically added to the list.

close #410

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Oct 6, 2020
@yun-yeo yun-yeo requested a review from hanjukim October 6, 2020 09:53
@yun-yeo yun-yeo added devops installation, deployment and node management wasm Wasm contract related update enhancement New feature or request labels Oct 6, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #413 into develop will decrease coverage by 0.19%.
The diff coverage is 58.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #413      +/-   ##
===========================================
- Coverage    67.70%   67.51%   -0.20%     
===========================================
  Files          117      117              
  Lines         5038     5051      +13     
===========================================
- Hits          3411     3410       -1     
- Misses        1415     1427      +12     
- Partials       212      214       +2     
Impacted Files Coverage Δ
app/app.go 92.04% <ø> (ø)
x/market/handler.go 79.31% <ø> (-0.36%) ⬇️
x/wasm/internal/keeper/contract.go 79.05% <21.42%> (-5.10%) ⬇️
x/wasm/internal/keeper/keeper.go 80.00% <81.25%> (-3.12%) ⬇️
x/wasm/handler.go 89.09% <100.00%> (+0.30%) ⬆️
x/wasm/internal/keeper/querier.go 24.61% <100.00%> (ø)

@hanjukim hanjukim merged commit 0c2b239 into develop Oct 19, 2020
@hanjukim hanjukim deleted the feature/events-emit branch October 19, 2020 10:58
@yun-yeo yun-yeo mentioned this pull request Nov 23, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops installation, deployment and node management enhancement New feature or request wasm Wasm contract related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] config to restrict log size from WASM module
2 participants