-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] WASM logging whitelist #413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
added
devops
installation, deployment and node management
wasm
Wasm contract related update
enhancement
New feature or request
labels
Oct 6, 2020
Codecov Report
@@ Coverage Diff @@
## develop #413 +/- ##
===========================================
- Coverage 67.70% 67.51% -0.20%
===========================================
Files 117 117
Lines 5038 5051 +13
===========================================
- Hits 3411 3410 -1
- Misses 1415 1427 +12
- Partials 212 214 +2
|
…t after new contract added to whitelist
…t/core into feature/events-emit
hanjukim
approved these changes
Oct 19, 2020
hanjukim
approved these changes
Oct 19, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
installation, deployment and node management
enhancement
New feature or request
wasm
Wasm contract related update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Now the contracts can emit bunch of logs without any cost. To restrict those resource waste, this update will allow a node operation to set whitelist addresses for
from_contract
event logging.Automatic Whitelisting
The node software will automatically adds newly instantiated contract address to the list if the instantiator's address is in the whitelist. As a result, all contracts address including contract initiated by contracts will also automatically added to the list.
close #410
Report of required housekeeping
(FOR ADMIN) Before merging