Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add unsafe-cors flag #409

Closed
yun-yeo opened this issue Sep 25, 2020 · 2 comments · Fixed by #420
Closed

[FEATURE] Add unsafe-cors flag #409

yun-yeo opened this issue Sep 25, 2020 · 2 comments · Fixed by #420
Assignees
@yun-yeo
Labels
enhancement New feature or request

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Sep 25, 2020 •
edited
Loading

Problem definition
Add a flag to the rest server that if a service provider is fine with accepting all cors.

Feature specification
cosmos/cosmos-sdk#5671
@yun-yeo yun-yeo added the enhancement New feature or request label Sep 25, 2020
@yun-yeo yun-yeo self-assigned this Sep 25, 2020
@hanjukim
Copy link
Contributor

I can see --unsafe-cors from terracli rest-server --help and LocalTerra is using it now. Can we close this issue?

@yun-yeo yun-yeo mentioned this issue Oct 27, 2020
Merged
8 tasks
@yun-yeo
Copy link
Contributor Author

yun-yeo commented Oct 27, 2020

It has the flag but we need to apply that flag option to rest-server instance. I did it on the above PR

@movaldivia movaldivia mentioned this issue Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yun-yeo yun-yeo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature] add a flag to the rest server to accept all cors terra-money/classic-core
2 participants
@hanjukim @yun-yeo