Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngularJS change: Add ability to handle NaNs to $watchCollection #52

Closed
teropa opened this issue Mar 26, 2014 · 2 comments
Closed

AngularJS change: Add ability to handle NaNs to $watchCollection #52

teropa opened this issue Mar 26, 2014 · 2 comments

Comments

@teropa
Copy link
Owner

teropa commented Mar 26, 2014

Applying angular/angular.js#4605

@teropa teropa changed the title Add ability to handle NaNs to $watchCollection AngularJS change: Add ability to handle NaNs to $watchCollection Mar 29, 2014
@teropa
Copy link
Owner Author

teropa commented Mar 29, 2014

Note to readers: This is added in Chapter 3, pages 76-77.

@teropa teropa closed this as completed Mar 29, 2014
@Foxandxss
Copy link
Contributor

For the ones who are up to date, the actual change is on the last else of the function:

} else {
  if (!self.$$areEqual(newValue, oldValue, false)) {
    changeCount++;
  }
  oldValue = newValue;
}

return changeCount;

This plus the test on page 76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants