Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap python2.7 error message #420

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Wrap python2.7 error message #420

merged 1 commit into from
Aug 28, 2019

Conversation

PrajwalM2212
Copy link
Contributor

Wraps python2.7 error message with user-friendly error message

Resolves #362

Signed-off-by: Prajwal M [email protected]

Wraps python2.7 error message with user-friendly error message

Resolves tern-tools#362

Signed-off-by: Prajwal M <[email protected]>
@PrajwalM2212
Copy link
Contributor Author

@nishakm @rnjudge Can you review this ?

@PrajwalM2212
Copy link
Contributor Author

PrajwalM2212 commented Aug 28, 2019

In #362

The error is being hit in tern/classes/docker_image.py. Might consider using the traceback library: https://docs.python.org/3/library/traceback.html

Another option would be for Tern to check for dependencies somehow before running.

@rnjudge I chose to check for dependencies before running. If I wrap the error in docker_image.py, it may turn up in some other class, so I thought that it would good to check for dependencies before running.

@nishakm
Copy link
Contributor

nishakm commented Aug 28, 2019

@PrajwalM2212 this is a reasonable fix. I will merge this.

@nishakm nishakm merged commit bb13d9c into tern-tools:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap python2.7 error message with user-friendly error message
2 participants