JOSS review - License

[craig-willis]

Review issue: openjournals/joss-reviews#4707
Branch reviewed: release-0.2.4

Problem
JOSS requires that your repository include the full-text of an OSI approved license. See the Software License section of the review criteria. The current LICENSE file does not appear to be an OSI approved license. The DESCRIPTION indicates an MIT license.

If the MIT license has been selected, consider updating the LICENSE file based on the OSI template. (Also, I'm not sure what "MIT + file LICENSE" means in the DESCRIPTION).

[robchallen]

Many thanks for this and other comments which are all very helpful.

I went through a few iterations with the LICENSE files. CRAN have some specific ways they want the files which I now sort of understand, but required me taking out the original. I've added in a LICENCE.md file into this repo for github, which is ignored for CRAN submission. The 2 line LICENSE text file and DESCRIPTION entry "MIT + file LICENSE" is the correct incantation for CRAN.

[craig-willis]

Ah, that makes sense now. I wasn't aware of the CRAN license requirements but see now that this is a common approach. Did you push your change to Github? I don't see a new commit.

[robchallen]

Not yet.
I'll try and bundle a few things together, so it doesn't come at you piecemeal.
It will probably will take me a few days.
Do you close these issues or do I?

[craig-willis]

Sounds good.

As for closing the issues, I've confirmed with the editor that either of us can close an issue after it's been addressed. I'm happy to review any changes (or explanation of why changes don't need to be made) and close them. You're also welcome to close them and I'll let you know if I have any further concerns.

For JOSS, the main thing is that I communicate any concerns -- particularly that might block acceptance -- via the primary review issue. I don't plan on putting anything there until you've had a chance to respond to the open issues in this repo.

[robchallen]

Hi. I've worked through all your helpful comments. In the end I made quite a few changes which I will describe in the linked issues, and this has been very worthwhile. I've bundled all the changes into a new release (0.2.4.9000) in a new branch which can be found here:

https://github.com/terminological/dtrackr/tree/joss-fixes-0.2.4.9000

On this specific issue I've added a LICENCE.md file.

This now show up on the home page of GitHub also.

(p.s. I'll let you close the issues once reviewed)

[craig-willis]

Great. I'll complete my review based on that branch.

[craig-willis]

Revised branch: joss-fixes-0.2.4.9000

License looks good.