-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible typo in the source code #19
Comments
Interesting - I'll have a look at this tonight |
Yea, it's a bit sad that ESLint can't (?) handle such things. If there is such rule would be great. |
tunnckoCore
pushed a commit
to tunnckoCore/prompts
that referenced
this issue
Mar 2, 2018
fixes terkelg#35, closes terkelg#19 Signed-off-by: Charlike Mike Reagent <[email protected]>
Thanks. I've removed readline in the 'keypress' branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Heya. As ususal, i always review the whole code of libraries or whatever.
So found that the
this.rl
hereprompts/lib/elements/prompt.js
Lines 18 to 19 in 230c1a6
probably is meant to be the
rl
const, because thethis.rl
is not defined in any other place in the code base, even in that file.The text was updated successfully, but these errors were encountered: