fix(dynamic-forms): make sure hints and errors dont overlap #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly leveraging the mat-error element on components that use mat-form-field fixes this issue, but to achieve this we need to refactor how the error message is shown also add documentation on how to show the error message when creating a custom component
|
LGTM |
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
…#1222) properly leveraging the mat-error element on components that use mat-form-field fixes this issue, but to achieve this we need to refactor how the error message is shown also add documentation on how to show the error message when creating a custom component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
properly leveraging the mat-error element on components that use
mat-form-field fixes this issue, but to achieve this we need to
refactor how the error message is shown
also add documentation on how to show the error message when creating a
custom component
What's included?
Test Steps
npm run serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.