feat(dynamic-forms): allow elements to be disabled via configuration #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed because we were mixing reactive forms with template driven forms and this usage will be deprecated in angular 7 also used the covalent control value accessor mixin
since we are injecting the control instance into the underlying element form support was never needed
adding a disabled property to disable properties on the fly without the need of accessing the underlying form
JulieMarie
previously requested changes
Aug 14, 2018
There was a problem hiding this comment.
I don't like the how the disabled slider looks/works. It's not grayed out, but the dot grays out when you click on it. Title should be grayed out too.
Don't like the slider toggle. Title should be grayed out and larger font to match the others.
File upload button is still active even though element is disabled.
|
This is for the file-input issue: #1220 [Bug]: file-input doesnt handle disabled state via reactive forms. the slide-toggle is a material issue and thats how it works. |
|
jeremysmartt
approved these changes
Aug 15, 2018
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
…eradata#1219) * refactor(dynamic-forms): remove ngModel usage this is needed because we were mixing reactive forms with template driven forms and this usage will be deprecated in angular 7 also used the covalent control value accessor mixin * chore(): remove AbstractControlValueAccessor code since its not needed * fix(): form support was not needed in the dynamic elements since we are injecting the control instance into the underlying element form support was never needed * feat(dynamic-forms): allow elements to be disabled via configuration adding a disabled property to disable properties on the fly without the need of accessing the underlying form * fix(): disable input in dynamic file input * fix(): fix label scss for slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding a disabled property to disable properties on the fly without the
need of accessing the underlying form
What's included?
Test Steps
npm run serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.npm run build:libstill works.Screenshots or link to StackBlitz/Plunker
closes #1126