fix(breadcrumbs): clean up imports of observable creation methods #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change to import creation methods from rxjs. Without this change, consumers of covalent are obligated to install rxjs-compat. Closes Teradata#1208
|
Thank you for the PR 👍 |
emoralesb05
approved these changes
Aug 13, 2018
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
…radata#1209) * Change to import creation methods from rxjs. Without this change, consumers of covalent are obligated to install rxjs-compat. Closes Teradata#1208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of covalent are obligated to install rxjs-compat.
Closes #1208
Description
What's included?
Minor fix to imports in an experimental module.
Test Steps
Does not apply.
General Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.