Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datatable): Fix for ExpressionChangedAfterItHasBeenCheckedError on datatable demo with pagination #1198

Merged
merged 6 commits into from
Aug 3, 2018
Merged

fix(datatable): Fix for ExpressionChangedAfterItHasBeenCheckedError on datatable demo with pagination #1198

merged 6 commits into from
Aug 3, 2018

Conversation

jeremysmartt
Copy link
Collaborator

@jeremysmartt jeremysmartt commented Jul 17, 2018 •
edited by kyleledbetter
Loading

Description

Modified the filter method to be async Promise to avoid ExpressionChangedAfterItHasBeenCheckedError on datatable demo

closes #1023

What's included?

  • modified: src/app/components/components/data-table/data-table.component.ts

Test Steps

  • Checkout branch
  • npm run serve
  • Go to http://localhost:4200/#/components/data-table
  • Go to the Data Table with components section
  • Open the browser debug console
  • Change the Per Page to 100
  • See no error in console
  • See that the amount of rows in table changed

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:lib still works.
Screenshots or link to StackBlitz/Plunker

table

@jeremysmartt jeremysmartt self-assigned this Jul 17, 2018
@jeremysmartt jeremysmartt added this to the Release 2.0.0 milestone Jul 17, 2018
@emoralesb05 emoralesb05 merged commit 419396b into develop Aug 3, 2018
@emoralesb05 emoralesb05 deleted the fix/datatable-ExpressionChanged-1023 branch August 3, 2018 19:01
emoralesb05 pushed a commit that referenced this pull request Aug 3, 2018
@jeremysmartt
fix(datatable): change detection error on datatable demo with paginat…
3a497c3 
…ion (#1198)

* fix(datatable): Fix for ExpressionChangedAfterItHasBeenCheckedError on datatable demo with pagination

* Update documentation for filter to use async
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
@jeremysmartt @emoralesb05
fix(datatable): change detection error on datatable demo with paginat…
9616d0d 
…ion (Teradata#1198)

* fix(datatable): Fix for ExpressionChangedAfterItHasBeenCheckedError on datatable demo with pagination

* Update documentation for filter to use async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoralesb05 emoralesb05 emoralesb05 approved these changes

Assignees

@jeremysmartt jeremysmartt

Labels
ready for review ux lgtm
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.

ExpressionChangedAfterItHasBeenCheckedError occurs when page size changes on Data Table with components demo
3 participants
@jeremysmartt @emoralesb05 @kyleledbetter