fix(dynamic-forms): removed regex for name #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eradata/covalent into fix/dynamic-form-element-regex
ilsiepotamus
suggested changes
May 23, 2018
| @@ -49,7 +49,7 @@ export interface ITdDynamicElementConfig { | |||
| validators?: ITdDynamicElementValidator[]; | |||
| } | |||
|
|
|||
| export const DYNAMIC_ELEMENT_NAME_REGEX: RegExp = /^[a-zA-Z]+[a-zA-Z0-9-_]*$/; | |||
| export const DYNAMIC_ELEMENT_NAME_REGEX: RegExp = /^[^0-9][^\@]*$/; | |||
There was a problem hiding this comment.
what are you trying to capture with this regex?
There was a problem hiding this comment.
In the original unit tests, it's testing for a name starting with a number or a name with an ampersand in it. I do realize that the \ isn't necessary to escape the @.
There was a problem hiding this comment.
ok, so it actually is testing for what you want to be testing for, however. I just thought it was an odd pattern.
ilsiepotamus
approved these changes
May 24, 2018
emoralesb05
pushed a commit
that referenced
this pull request
May 25, 2018
* fix(dynamic-forms): removed regex for name * fix(dynamic-forms): modified regex to allow japanese/chinese chars * fix(dynamic-forms): got rid of spaces
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* fix(dynamic-forms): removed regex for name * fix(dynamic-forms): modified regex to allow japanese/chinese chars * fix(dynamic-forms): got rid of spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed regex from name string
Test Steps
npm run serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.Screenshots or link to StackBlitz/Plunker
Stackblitz with regex implemented
https://stackblitz.com/edit/ajc-stackoverflow-48705028?file=app/app.component.ts
