feat(cli): upgrade to @angular@cli@6 #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: prod build doesnt work.. there is a bug in the angular-cli when using prod build with locales.. |
jennmedellin
requested review from
jennmedellin
and removed request for
jennmedellin
|
Any updates for angular6? |
|
Covalent 2.0.0-beta.1 already support angular 6, this PR is just to point to stable and upgrade the CLI in the repo. |
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
* feat(cli): upgrade to @angular@cli@6 * chore(): generate coverage dir at root level * chore(): update dependencies and yarn.lock with latest cli dependencies * feat(): upgrade to angular stable * fix(): update commands for serve and build * chore(): update versions for build * chore(): add --watch=false to test command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to use the latest @angular@cli (v6) and apply its breaking changes.
What's included?
@angular@vli@6Test Steps
yarn installng serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:libstill works.Screenshots or link to StackBlitz/Plunker