feat(dependencies): upgrade covalent dependencies @[email protected] #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2018 16:13
|
http://localhost:4200/#/components/json-formatter |
|
http://localhost:4200/#/components/dynamic-forms |
|
http://localhost:4200/#/components/code-editor
|
ghost
self-requested a review
added 7 commits
January 19, 2018 09:09
|
The last find is in the |
emoralesb05
changed the title
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
…ata#1096) * chore(dependencies): upgrade covalent dependencies @angular@5.1 * perf(divider): import divider module instead of list module in layout and menu modules * feat(enums): leverage typescript string enums to remove the <any> cast * fix(chips): underline not working properly on 5.1 material * fix(chips): remove disabled chip since now we cant focus a chip if its disabled * chore(): rollback test.ts * fix(chips): deselect first option only if it has been selected before and was done internally * fix(docs): divider issue in json-formatter docs * fix(docs): divider issue in dynamic-forms docs * fix(docs): divider issue in layouts overview * fix(docs): divider issue in logo docs * fix(docs): divider issue in stepper pattern docs * fix(docs): divider issue in empty state pattern docs * feat(divider): replace matInset with [inset]="true" * chore(): upgrade to angular/cli 1.6.5 and TS 2.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that material introduced their
MatDividerModule, we can directly use it without usingMatListModule.. To be able to use this we need to upgrade material to 5.1So to keep consistency we are gonna have a minimal requirement of [email protected]
Test Steps
npm run serveGeneral Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:releasestill works.