Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-upload): change API from tables to lists #1085

Merged
merged 5 commits into from
Jan 16, 2018

Conversation

jennmedellin
Copy link
Collaborator

@jennmedellin jennmedellin commented Jan 15, 2018

Description

Show the API's as lists rather than data-tables.

Test Steps

  • npm run serve
  • Go to file upload button demo
  • See API in readme

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:release still works.
Screenshots or link to StackBlitz/Plunker

screen shot 2018-01-15 at 2 58 48 pm

Before (left), After (right)
screen shot 2018-01-15 at 3 08 22 pm

@jennmedellin jennmedellin changed the title feat(file-input): change API from tables to lists feat(file-upload): change API from tables to lists Jan 15, 2018
@emoralesb05 emoralesb05 added this to the Release Candidate 3 milestone Jan 15, 2018
@emoralesb05 emoralesb05 merged commit 308b626 into develop Jan 16, 2018
@emoralesb05 emoralesb05 deleted the feature/file-upload-readme branch January 16, 2018 23:35
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
…radata#1085)

* feat(file-upload): change API from tables to lists

* feat(file-upload): change API from tables to lists

* chore(): cleanup layout

* feat(file-upload): change API from tables to lists

* chore(): update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants