Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic-forms): replace API data-table with list in README #1084

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

emoralesb05
Copy link
Contributor

Description

Sinde now we support list rendering from markdown, we are going to show the API's as lists rather than data-tables.

Test Steps

  • npm run serve
  • Go to dynamic forms demo and see README

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run tslint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:release still works.

@emoralesb05 emoralesb05 added this to the Release Candidate 3 milestone Jan 15, 2018
@emoralesb05 emoralesb05 merged commit 1041d1f into develop Jan 16, 2018
@emoralesb05 emoralesb05 deleted the feature/dynamic-forms-readme branch January 16, 2018 23:20
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant