chore(): change to Covalent Angular package format build w/ ng-packagr #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2018 16:08
…anch last 2 branches were outdated and getting too dirty
…r consumption style to produce respective angular package format v5
added 17 commits
January 3, 2018 16:39
… breaking npm run serve
… scripts used for building @covalent/core and testing ssr
For paging, virtual-scroll, notifications, and common.
Example for paging:
import { CovalentPagingModule } from '@covalent/core';
import { CovalentPagingModule } from '@covalent/core/paging';
...
…ckangr hack work around
ghost
force-pushed
the
angular-package-format-build
branch
from
57fc89b to
eb5bdf3
Compare
added 8 commits
January 9, 2018 13:10
added 10 commits
January 11, 2018 11:39
ghost
changed the title
ghost
changed the title
ghost
changed the title
emoralesb05
reviewed
Jan 15, 2018
| @@ -2,9 +2,6 @@ | |||
| "name": "@covalent/core", | |||
| "version": "1.0.0-rc.2", | |||
| "description": "Teradata UI Platform built on Angular Material", | |||
| "main": "./bundles/core.umd.js", | |||
| "module": "./index.js", | |||
| "typings": "./index.d.ts", | |||
There was a problem hiding this comment.
Why are we removing this? does the ng-packegr add this automatically?
There was a problem hiding this comment.
Ah, nvm just saw that they are generated 👍
emoralesb05
changed the title
emoralesb05
approved these changes
Jan 15, 2018
kriswinbush
pushed a commit
to kriswinbush/covalent
that referenced
this pull request
Feb 20, 2020
…Teradata#1065) * feat(): cherry-pick over inital ssr research/solution to new clean branch last 2 branches were outdated and getting too dirty * feat(): mod paging, virtual scroll, notifications to follow ng-packagr consumption style to produce respective angular package format v5 * feat(): push yarn.lock update * feat(): ng-packagr mod for @covalent/common and resove new file paths breaking npm run serve * feat(): common folder setup for Angular Package Format and cleaned up scripts used for building @covalent/core and testing ssr * fix(): forgot to save merge conflict resolution * refactor(): remove outdated custom build config * refactor(): remove package-lock.json * feat(): enable imports from secondary entry points For paging, virtual-scroll, notifications, and common. Example for paging: import { CovalentPagingModule } from '@covalent/core'; import { CovalentPagingModule } from '@covalent/core/paging'; ... * fix(): linting issue * fix(): breaking test because of import location * feat(): Angular package format build for /messages with /common ng-packangr hack work around * feat(): mod build path to be deploy/platform instead of dist/ * feat(): fix linting issue * fix(): remove message export from message.module and update common public_api * feat(): ng-packagr setup for chips * feat(): ng-packagr setup for data-table * fix(): forgot to export chips in platform/index * feat(): ng-packagr setup for dialogs * fix(): export dialogs from core public-api * feat(): ng-packagr setup for expansion-panel * feat(): ng-packagr setup for file * feat(): ng-packagr setup for json-formatter * fix(): breaking test because of filepath * feat(): ng-packagr setup for layout * feat(): ng-packagr setup for loading * feat(): ng-packagr setup for media * feat(): ng-packagr setup for menu * feat(): ng-packagr setup for search * ng-packagr setup for steps * feat(): clean up post ng-packagr conversion for /core * feat(): move and build required files that ng-packagr doesn't handle * fix(): breaking testing because of file path * feat(): ng-packagr setup for primary entrypoint: dynamic-forms * feat(): ng-packagr setup for primary entrypoint: highlight * feat(): ng-packagr setup for primary entrypoint: http * feat(): ng-packagr setup for primary entrypoint: markdown * feat(): updated ng-packangr to 2.0.0-rc.0 * fix(): double exporting * feat(): upgrade ng-packagr to 2.0.0-rc-6 * feat(): upgrade ng-packagr to 2.0.0-rc-7 and consolidated ng-package settings * fix(): change ng-packagr.json to ng-packagr.js for last ng-packagr update * feat(): upgrade ng-packagr to 2.0.0-rc-8 * feat(): upgrade ng-packagr to 2.0.0-rc-10 * refactor(): clean up + consolidate code/scripts * refactor(): additional clean up * fix(): linting issues * chore(): delete unneeded tsconfig-aot.json * chore(): set -e in build scripts to stop script if it fails * chore(): ignore failure if .tgz pack is not there * fix(): test run different sed command based on platform * refactor(): remove platform echo test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be able to enable and measure server side rendering capability of a library and gain additional benefits such as tree shaking though primary/secondary entry points and much more. A library must follow the Angular Package Format to gain these benefits.
What's included?
Test Steps
npm run reinstallBasic testing
npm run build:release, verify thedeploy/platform/*is outputting as Angular Package Format.npm run build:universal, verify that the subset of components being tested are outputing server based rendered content.npm run serve, verify all components/directives/demos are working accordinglyAdvanced testing
npm install --save @covalent/coreor any of the other primary entry points. Install @covalent/* into the new project by first runningnpm run build:releasein this repo then in each of the primary entry point folder (ex: /deploy/platform/core, /deploy/platform/dynamic-forms) runnpm pack. Then in the new project runnpm install <file-path-to-*.tgz>on each of the generated packed file. Verify that you can use every component/directive though both the primary entry points@covalent/core, @covalent/dynamic-forms, @covalent/highlight, @covalent/http, @covalent/markdownand secondary entry points@covalent/core/paging, @covalent/core/loading, @covalent/chips, ect.... (if your using yarn you can use yarn link instead of npm pack/npm install)node_module/@covalent/*before installing the packages from this repo.General Tests for Every PR
npm run serve:prodstill works.npm run tslintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run build:releasestill works.