Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(json-formatter): support properly RTL #1033

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

Show functions, dates and array lengths properly in RTL when using the json-formatter component,

Test Steps

  • npm run serve
  • Go to json-formatter demo
  • Compare with getcovalent.com

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build:release still works.

Part of #323

@emoralesb05 emoralesb05 added this to the Release Candidate 2 milestone Dec 14, 2017
@emoralesb05 emoralesb05 merged commit 90903d0 into develop Dec 15, 2017
@emoralesb05 emoralesb05 deleted the feature/json-formatter-rtl branch December 15, 2017 00:52
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant