Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(): make LayoutToggle class reuse disable mixin #1022

Merged
merged 2 commits into from
Dec 13, 2017
Merged

feat(): make LayoutToggle class reuse disable mixin #1022

merged 2 commits into from
Dec 13, 2017

Conversation

emoralesb05
Copy link
Contributor

Description

Making we leverage the disable mixin everywhere we use a disable input.

Test Steps

  • npm run serve
  • See layout button still work the same

General Tests for Every PR

  • npm run serve:prod still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

@emoralesb05 emoralesb05 added this to the Release Candidate 1 milestone Dec 10, 2017
@emoralesb05 emoralesb05 merged commit d42825f into develop Dec 13, 2017
@emoralesb05 emoralesb05 deleted the feature/layout-disable branch December 13, 2017 00:09
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
@emoralesb05
feat(): make LayoutToggle class reuse disable mixin (Teradata#1022)
abc16c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release Candidate 2
Development

Successfully merging this pull request may close these issues.
1 participant
@emoralesb05