fix(datatable): change detection error on datatable demo with paginat…

…ion (#1198) * fix(datatable): Fix for ExpressionChangedAfterItHasBeenCheckedError on datatable demo with pagination * Update documentation for filter to use async
Teradata · Aug 3, 2018 · 419396b · 419396b
1 parent 44f2212
commit 419396b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/app/components/components/data-table/data-table.component.html b/src/app/components/components/data-table/data-table.component.html
@@ -324,19 +324,19 @@ <h3>No results to display.</h3>
                 // .. do something with event.row
               }
 
-              filter(): void {
+              async filter(): Promise<void> {
                 let newData: any[] = this.data;
-                let excludedColumns: string[] = this.columns
+                let excludedColumns: string[] = await this.columns
                 .filter((column: ITdDataTableColumn) => {
                   return ((column.filter === undefined && column.hidden === true) || 
                           (column.filter !== undefined && column.filter === false));
                 }).map((column: ITdDataTableColumn) => {
                   return column.name;
                 });
-                newData = this._dataTableService.filterData(newData, this.searchTerm, true, excludedColumns);
+                newData = await this._dataTableService.filterData(newData, this.searchTerm, true, excludedColumns);
                 this.filteredTotal = newData.length;
-                newData = this._dataTableService.sortData(newData, this.sortBy, this.sortOrder);
-                newData = this._dataTableService.pageData(newData, this.fromRow, this.currentPage * this.pageSize);
+                newData = await this._dataTableService.sortData(newData, this.sortBy, this.sortOrder);
+                newData = await this._dataTableService.pageData(newData, this.fromRow, this.currentPage * this.pageSize);
                 this.filteredData = newData;
               }
             }

diff --git a/src/app/components/components/data-table/data-table.component.ts b/src/app/components/components/data-table/data-table.component.ts
@@ -156,19 +156,19 @@ export class DataTableDemoComponent implements OnInit {
     this.filter();
   }
 
-  filter(): void {
+  async filter(): Promise<void> {
     let newData: any[] = this.data;
-    let excludedColumns: string[] = this.columns
+    let excludedColumns: string[] = await this.columns
     .filter((column: ITdDataTableColumn) => {
       return ((column.filter === undefined && column.hidden === true) || 
               (column.filter !== undefined && column.filter === false));
     }).map((column: ITdDataTableColumn) => {
       return column.name;
     });
-    newData = this._dataTableService.filterData(newData, this.searchTerm, true, excludedColumns);
+    newData = await this._dataTableService.filterData(newData, this.searchTerm, true, excludedColumns);
     this.filteredTotal = newData.length;
-    newData = this._dataTableService.sortData(newData, this.sortBy, this.sortOrder);
-    newData = this._dataTableService.pageData(newData, this.fromRow, this.currentPage * this.pageSize);
+    newData = await this._dataTableService.sortData(newData, this.sortBy, this.sortOrder);
+    newData = await this._dataTableService.pageData(newData, this.fromRow, this.currentPage * this.pageSize);
     this.filteredData = newData;
   }