-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google
module of cirq
has been moved to a separate module
#307
Comments
That would be amazing! What would be great to add a small test alongside (in import importlib
HAS_GOOGLE = importlib.util.find_spec('cirq_google')
@pytest.mark.skipif(condition=HAS_GOOGLE, reason="cirq_google not installed")
def test_cirq_google_devices():
some tests and in the same way, including the |
Hi Jakob, It seems that a lot has changed in the I am currently working out the details, but I would refactor the
|
Looks good to me! would suggest the following error handling, then the original Exception from cirq is also displayed (often useful) except ValueError as E:
original_message = str(E)
raise TequilaCirqException('original message:\n{}\n\ncould not optimize for device={}'.format(original_message,device)) |
Describe the bug
When trying to use the
sycamore
device for simulating my wavefunction, I get the errorAttributeError: module 'cirq' has no attribute 'google'
because thecirq.google
module has been moved into its own modulecirq_google
.To Reproduce
Steps to reproduce the behavior:
Computer (please complete the following information):
Additional context
I think the bugfix would consist of renaming all
cirq.google
references tocirq_google
(need to check thoroughly) and adding thecirq_google
package to the optional backends list in therequirements.txt
. I can provide this in a new PR if you want?The text was updated successfully, but these errors were encountered: