Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset: Duplicated checks for Arm architecture, lacking explanation #6

Open
afaerber opened this issue Sep 12, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@afaerber
Copy link
Contributor

As visible in #5, both wh_reset.py and bh_reset.py have open-coded checks for Arm architecture.
This should probably be refactored into a common function called by both, so that they don't start deviating.

Also, both sites do not offer further explanatory comments as to why PCIe rescan would not work on Arm. Is this really an architectural issue or just related to specific PCIe host controller drivers or to some quirk on a specific vendor chip? If architectural, how would we know whether any other architecture may need to be added to that check? (for example, have RISC-V host systems like HiFive Unmatched been verified?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants