Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle incorrect CLI arguments in tt-smi #15

Open
hmohiuddinTT opened this issue Mar 28, 2024 · 4 comments
Open

Properly handle incorrect CLI arguments in tt-smi #15

hmohiuddinTT opened this issue Mar 28, 2024 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request internal_report

Comments

@hmohiuddinTT
Copy link

hmohiuddinTT commented Mar 28, 2024

Tried to run tt-rmi -r with multiple device ids but the program crashed. Should do some argparsing and fail gracefully with a cleaner error message.
image

@sbansalTT
Copy link
Contributor

Looks like there is a device id 8 doesn't exist on the pci bus. Could you remove it and try again?
But, I will also add a cleaner exit when the device isn't found - to make it easier for user to debug

@hmohiuddinTT
Copy link
Author

Oh yeah I didn't even realize I added an extra device, but yeah we should still handle it gracefully.

@hmohiuddinTT hmohiuddinTT added the bug Something isn't working label Mar 29, 2024
@warthog9 warthog9 added enhancement New feature or request internal_report labels Apr 26, 2024
@warthog9
Copy link
Member

more try/except blocks! ;-)

@knauth
Copy link
Contributor

knauth commented Dec 17, 2024

This isn't an easy fix on the Python side, since Rust panics aren't thrown as regular Exceptions in pyO3, but rather inherit from BaseException. We can catch the BaseException but it'll still print the Rust panic and could cause issues with safety. This needs to be changed on the Luwen side to throw an error rather than panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request internal_report
Projects
None yet
Development

No branches or pull requests

4 participants