Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations in TT-Scatter Op #4294

Open
Sudharsan-V opened this issue Dec 12, 2023 · 1 comment
Open

Limitations in TT-Scatter Op #4294

Sudharsan-V opened this issue Dec 12, 2023 · 1 comment

Comments

@Sudharsan-V
Copy link
Contributor

The current version of the TT scatter operation falls short of providing the full functionality available in the PyTorch scatter operation.
Specifically, the scatter operation necessitates the index tensor (parameter) to be of the int64 data type, which is currently unsupported. Additionally, the constraint on accessing tensor elements through indexing represents a limitation in our use case.

As a result of these limitations, the full realization of the TT scatter operation's utility is hindered, thereby adversely impacting the results of the gs-demo.

Result when using TT-scatter op


Input prompt: A man is sitting on a roof
Output: A man is sitting on a roof.\nis a man a mantrafficacy. A. A+W, aka.1000.1 and #12000.1\n dévelop, #1, #10.10.10.'

@ajakovljevicTT
Copy link
Contributor

Hi all, we've hit the problem of scatter not supporting full torch functionality relating to starting indexes when converting the StableHLO dialect and lowering to MLIR. Do we have perhaps have a roadmap for full support of the scatter op?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants