Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-sdk make test target to run all python-sdk tests #1061

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

eabatalov
Copy link
Contributor

make test command now provides full official set of unit and integration tests for python-sdk. They can be started using the command during development and in CI. This is why PR template is updated with the command and GitHub CI actions run it now.

Contribution Checklist

  • [n/a] If the python-sdk was changed, please run make fmt in python-sdk/.
  • [n/a] If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

`make test` command now provides full official set of unit and
integration tests for python-sdk. They can be started using the
command during development and in CI. This is why PR template is
updated with the command and GitHub CI actions run it now.

Also use `make build` command instead of calling `poetry install`
exlicitly in CI because `make build` is a source of truth command
for building of python-sdk (it runs `poetry install` too).
@eabatalov eabatalov force-pushed the eugene-python-sdk-run-all-tests branch from 4a128d0 to f26fdf1 Compare November 22, 2024 11:34
@eabatalov eabatalov requested a review from seriousben November 22, 2024 11:50
@eabatalov eabatalov marked this pull request as ready for review November 22, 2024 11:51
@eabatalov eabatalov merged commit 20c3274 into main Nov 22, 2024
5 checks passed
@eabatalov eabatalov deleted the eugene-python-sdk-run-all-tests branch November 22, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants