Run Poetry install before poetry build command in Makefile #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building Python SDK project requires all Poetry dependencies to be installed first. Also adding install command ensures that all dependencies are updating during development if they are changes in pyproject.toml. Poetry install is exiting in a few ms if everything is installed already so this doesn't add extra delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building Python SDK project requires all Poetry dependencies to be installed first. Also adding install command ensures that all dependencies are updating during development if they are changes in pyproject.toml.
Poetry install is exiting in a few ms if everything is installed already so this doesn't add extra delay.
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.