chore(ci): fix false positive lint issues + speedup CI #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriousben
force-pushed
the
seriousben/fix-false-positive-lint-issues
branch
3 times, most recently
from
b6a69a5 to
8a4ea5d
Compare
seriousben
force-pushed
the
seriousben/fix-false-positive-lint-issues
branch
from
8a4ea5d to
a6603b8
Compare
seriousben
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CI has been complaning of lint issues that we cannot fix or see locally.
What
Using the poetry managed version instead of installing linting tools in CI.
Also speeding up CI by more than half (from 8m to 3m) by not rebuilding the server twice.
Also reorganizing CI for faster feedback loops around Python vs Server vs UI lint and build errors.
Testing
Look at CI
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.