Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): default compute graph replaying to false when deserialzing #1042

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(server): default compute graph replaying to false when deserialzing #1042

merged 1 commit into from
Nov 19, 2024

Conversation

seriousben
Copy link
Member

@seriousben seriousben commented Nov 19, 2024 •
edited
Loading

Context

Fixes #1041

What

When deserializing a previously created compute graph, the missing replaying field would cause an error.

Testing

Running a the test_graph_update.py test.

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben seriousben changed the title fix(server): default compute grapgh replaying to false when deserialzing fix(server): default compute graph replaying to false when deserialzing Nov 19, 2024
@diptanu diptanu merged commit 0447257 into main Nov 19, 2024
6 checks passed
@diptanu diptanu deleted the seriousben/default-replaying-field branch November 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New compute graph replaying field prevents deserializing previously existing compute graphs
2 participants
@seriousben @diptanu