-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove msgpack from python-sdk and support application/json response from rust server #1025 and #1030 #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default2882
force-pushed
the
remove_msgpack
branch
from
November 14, 2024 04:40
feb8c15
to
37a111a
Compare
Default2882
changed the title
[WIP] Remove msgpack from python-sdk, addresses #1025
Remove dependency on Nov 14, 2024
msgpack
from python-sdk, addresses #1025
@Default2882 This looks fine to me. Let's merge this once we have the other pieces for doing JSON end to end. |
diptanu
requested changes
Nov 16, 2024
…ssary logs statements in download.rs
…so that we don't store nested Indexify object. Added 2 changes in task_reporter.py - - to include content_type in output of the function. - to only send the payload (json/bytes) to the server and not the whole IndexifyObject
Default2882
changed the title
Remove dependency on
Remove msgpack from python-sdk and support application/json response from rust server #1025 and #1030
Nov 16, 2024
msgpack
from python-sdk, addresses #1025
diptanu
requested changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Completely removes dependency on
msgpack
in python-sdk, and now indexify supports both json and bytes encoding for input data. This change is for #1025 and #1030.Testing
Added new graph behaviour test for graph with json as well as cloudpickle encoding.
Manual Testing -
Contribution Checklist
make fmt
inpython-sdk/
.make fmt
inserver/
.