Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server,sdk)!: rename rerun to replay_invocations for clarity #1022

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

seriousben
Copy link
Member

@seriousben seriousben commented Nov 12, 2024

Context

The current term rerun is confusing especially when compared with the run method.

Example 1:

invocation_id = g.run(block_until_done=True, x=Object(x="a"))

Example 2:

g.rerun()

The code difference between Example 1 and 2 is minimal but the impact on the graph's data is immense. Example 2 will go through all previous runs/invocations and will execute them again but on the latest version of the graph.

What

We are renaming rerun to replay_invocation in the SDK and in the server to remove any possible confusion.

Testing

The test_graph_update.py tests replay.

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben seriousben requested a review from diptanu November 12, 2024 21:09
@seriousben seriousben merged commit 383d5db into main Nov 12, 2024
5 checks passed
@seriousben seriousben deleted the seriousben/rename-rerun-to-replay branch November 12, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants