feature(sdk): support graph deletion #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptanu
approved these changes
Nov 12, 2024
python-sdk/indexify/http_client.py
Outdated
| cert_path=cert_path, | ||
| key_path=key_path, | ||
| ca_bundle_path=ca_bundle_path | ||
| cert_path=cert_path, key_path=key_path, ca_bundle_path=ca_bundle_path |
There was a problem hiding this comment.
Did you run make fmt Feels like this would be re-formatted back to what we had before.
seriousben
force-pushed
the
seriousben/sdk-graph-deletion
branch
2 times, most recently
from
486dd16 to
814cb76
Compare
seriousben
force-pushed
the
seriousben/sdk-graph-deletion
branch
2 times, most recently
from
79317c1 to
fdd5dcd
Compare
seriousben
added
the
ci_compat_test
seriousben
force-pushed
the
seriousben/sdk-graph-deletion
branch
from
fdd5dcd to
91e6fa0
Compare
seriousben
removed
the
ci_compat_test
seriousben
force-pushed
the
seriousben/sdk-graph-deletion
branch
from
91e6fa0 to
261d47c
Compare
seriousben
force-pushed
the
seriousben/sdk-graph-deletion
branch
from
261d47c to
c6ced75
Compare
|
@diptanu - I made it so that linting will be enforced by CI starting now. I also made the last release acceptance gated behind a specific label since it is expected to fail a lot until we get to v1.0 - I do think that last release test is useful to be intentional about breaking changes. Will be merging this asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is currently no way to delete a compute graph using the SDK.
What
A new
delete_compute_graphfunction is added to theIndexifyClient.Testing
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.