Add tests for simple graph, with multiple inputs #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptanu
reviewed
Nov 11, 2024
| @@ -208,6 +215,18 @@ def test_simple_function(self, is_remote): | |||
| output = graph.output(invocation_id, "simple_function") | |||
| self.assertEqual(output, [MyObject(x="ab")]) | |||
|
|
|||
| # @parameterized.expand([(False), (True)]) | |||
There was a problem hiding this comment.
This probably shouldn't be commented.
There was a problem hiding this comment.
Ran into this on my laptop testing,ModuleNotFoundError: No module named 'test_graph_behaviours'. I just pushed the PR to run the test and see if it worked. Will fix.
| @@ -208,6 +215,18 @@ def test_simple_function(self, is_remote): | |||
| output = graph.output(invocation_id, "simple_function") | |||
| self.assertEqual(output, [MyObject(x="ab")]) | |||
|
|
|||
| # @parameterized.expand([(False), (True)]) | |||
| def test_simple_function_multiple_inputs(self, is_remote=True): | |||
| print(sys.version_info.major, sys.version_info.minor) | |||
| @@ -28,6 +29,12 @@ def simple_function(x: MyObject) -> MyObject: | |||
| return MyObject(x=x.x + "b") | |||
|
|
|||
|
|
|||
| @indexify_function() | |||
There was a problem hiding this comment.
Probably worth testing if this works with json encoding as well. May be it works.
stangirala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a couple of tests for a simple graph function where the function takes in multiple inputs. This should work given how we setup the args but we didn't have a test for it. Also add test, for sanity, with json encoding.
What
Add tests for graph behaviours. This will run as a workflow action.
Testing
N/A
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.