Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittest toggle for remote and local tests #1013

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Add unittest toggle for remote and local tests #1013

merged 4 commits into from
Nov 9, 2024

Conversation

stangirala
Copy link
Collaborator

Context

test_graph_behaviours.py has several tests for the core indexify functions. We should be able to run these tests either locally or as a Remote deployment (ie. starting a server and executor). Right now it's hard-coded for Remote testing.

What

Add an env toggle before running the unit test and use it to either setup a remote or local graph.

Testing

Verified toggle works.

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

Copy link
Collaborator

@diptanu diptanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Please merge after the tests passes. You need to update the Github Actions too.

@stangirala stangirala merged commit 6256483 into main Nov 9, 2024
2 checks passed
@stangirala stangirala deleted the local-test branch November 9, 2024 21:05
stangirala added a commit that referenced this pull request Nov 9, 2024
stangirala added a commit that referenced this pull request Nov 10, 2024
stangirala added a commit that referenced this pull request Nov 10, 2024
Revert "Revert "Add unittest toggle for remote and local tests (#1013)""

This reverts commit 2fce01a.
@stangirala stangirala mentioned this pull request Nov 10, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants