Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature_selection component? #160

Closed
rcrowe-google opened this issue Aug 11, 2022 · 2 comments · Fixed by #161
Closed

Add feature_selection component? #160

rcrowe-google opened this issue Aug 11, 2022 · 2 comments · Fixed by #161
Assignees
@casassg

Comments

@rcrowe-google
Copy link
Collaborator

The feature selection component doesn't seem to be an active module:

tfx_addons._ACTIVE_MODULES

['__version__',
 'mlmd_client',
 'schema_curation',
 'feast_examplegen',
 'xgboost_evaluator',
 'sampling',
 'message_exit_handler']

Can we add it?
@rcrowe-google
Copy link
Collaborator Author

rcrowe-google commented Aug 11, 2022 •
edited
Loading

@deutranium

@casassg
Copy link
Member

casassg commented Aug 12, 2022

We need a set of needed deps added here: https://github.com/tensorflow/tfx-addons/blob/main/tfx_addons/version.py#L49

@casassg casassg mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casassg casassg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature_selection to included pkg tensorflow/tfx-addons
2 participants
@casassg @rcrowe-google