Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin asset traversal logic #1943

Open
nfelt opened this issue Mar 2, 2019 · 0 comments
Open

Improve plugin asset traversal logic #1943

nfelt opened this issue Mar 2, 2019 · 0 comments

Comments

@nfelt
Copy link
Contributor

nfelt commented Mar 2, 2019

The legacy plugin asset system, for better or for worse, still doesn't have a good replacement. The built-in functionality in EventMultiplexer to retrieve lists of plugin assets is extremely slow (it traverses every single run directory, every time you call it), which has required plugins who depend on this retrieval process to resort to running it asynchronously in order to not block in is_active() or HTTP request processing.

We should rework this logic so it happens as part of the regular Reload() cycle for the EventMultiplexer, on the existing background thread, and the results are cached for quick retrieval.

This way we can stop implementing one-off threaded workarounds for the following plugins:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant