You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The legacy plugin asset system, for better or for worse, still doesn't have a good replacement. The built-in functionality in EventMultiplexer to retrieve lists of plugin assets is extremely slow (it traverses every single run directory, every time you call it), which has required plugins who depend on this retrieval process to resort to running it asynchronously in order to not block in is_active() or HTTP request processing.
We should rework this logic so it happens as part of the regular Reload() cycle for the EventMultiplexer, on the existing background thread, and the results are cached for quick retrieval.
This way we can stop implementing one-off threaded workarounds for the following plugins:
The legacy plugin asset system, for better or for worse, still doesn't have a good replacement. The built-in functionality in EventMultiplexer to retrieve lists of plugin assets is extremely slow (it traverses every single run directory, every time you call it), which has required plugins who depend on this retrieval process to resort to running it asynchronously in order to not block in
is_active()
or HTTP request processing.We should rework this logic so it happens as part of the regular Reload() cycle for the EventMultiplexer, on the existing background thread, and the results are cached for quick retrieval.
This way we can stop implementing one-off threaded workarounds for the following plugins:
Projector plugin (async for
is_active()
, sync for serving path) - see Make is_active for projector return quickly #326tensorboard/tensorboard/plugins/projector/projector_plugin.py
Lines 460 to 466 in 387d52f
Text plugin (async for both
is_active()
and serving path) - see Change TextPlugin to compute index_impl() asynchronously #663tensorboard/tensorboard/plugins/text/text_plugin.py
Lines 285 to 298 in 387d52f
Profile plugin (async for
is_active()
; sync for the serving path) - see Make profile plugin use EventMultiplexer to find data in subdirectories #1931tensorboard/tensorboard/plugins/profile/profile_plugin.py
Line 259 in 387d52f
The text was updated successfully, but these errors were encountered: