Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire log directory fetched from GCS during each periodic reload #1005

Closed
chihuahua opened this issue Feb 26, 2018 · 3 comments
Closed

Entire log directory fetched from GCS during each periodic reload #1005

chihuahua opened this issue Feb 26, 2018 · 3 comments

Comments

@chihuahua
Copy link
Member

chihuahua commented Feb 26, 2018

This issue relates to #158. During each periodic reload (which by default happens every 5 seconds), TensorBoard fetches the entire log directory from GCS. This incurs very high costs for large log directories.

@chihuahua chihuahua changed the title Entire log directory fetched when Entire log directory fetched from GCS during each periodic reload Feb 26, 2018
@nfelt
Copy link
Contributor

nfelt commented Feb 26, 2018

Hmm, is this really worth tracking separately from #158? That one already says this in the second comment: "it seems that every reload directly from GCP causes every single file to be accessed separately via the GCS api ."

@nfelt
Copy link
Contributor

nfelt commented Feb 26, 2018

I guess if we consider #158 to be more about general slowness (as described in the OP) even on reading directly from a single GCS file, then it is a separate issue that we're doing too many file accesses overall, so maybe it does make sense to keep this one for that latter concern. Up to you.

When you say "entire log directory" what exactly do you mean? Are we actually attempting to fetch the entire contents of every event file on every reload? I would have thought that DirectoryWatcher would ensure that we were only attempting to read the most recent event file within each run.

@chihuahua
Copy link
Member Author

Actually, yeah, lets track via #158. Stakeholders are already on that thread. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants