projector: add notebook renderer #187
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces Python API to render the new projector in Juypter notebook. It currently provides work in progress API, `embedding` which visualizes the embedding data and label rendered in the visualization. In order to support both Colab and Jupyter, I have decided to introduce an abstraction, `renderer` which knows how to render an output cell and how to communicate with it. Do note that Jupyter and Colab are very different; Jupyter does not encapsulate JavaScript context for each output cell so a symbol exposed on `globalThis` bleeds over to other output cells while Colab does not do that.
|
I think were just missing some type annotations. Looks like the static typing tests are failing for tensorflow_similarity/visualization/projector_v2/notebook.py:71 |
|
Thanks for taking a look at the CI. I am doing the work on the side and will get to it when ready. Also, will mark the PR as "Ready for review" when it is truly ready. |
|
Sounds good, thanks! |
owenvallis
added a commit
that referenced
this pull request
Jul 12, 2022
Moved the projector_v2 code to a separate branch until PR #187 is ready.
abeltheo
pushed a commit
to abeltheo/similarity
that referenced
this pull request
Mar 23, 2023
Moved the projector_v2 code to a separate branch until PR tensorflow#187 is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces Python API to render the new projector in Juypter
notebook. It currently provides work in progress API,
embeddingwhichvisualizes the embedding data and label rendered in the visualization.
In order to support both Colab and Jupyter, I have decided to introduce
an abstraction,
Rendererwhich knows how to render an output cell andhow to communicate with it. Do note that Jupyter and Colab are very
different; Jupyter does not encapsulate JavaScript context for each
output cell so a symbol exposed on
globalThisbleeds over to otheroutput cells while Colab does not do that.