Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated Dockerfile.gpu to install cuda-toolkit #2202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

updated Dockerfile.gpu to install cuda-toolkit #2202

wants to merge 3 commits into from

Conversation

singhniraj08
Copy link

updated Dockerfile.gpu to install cuda-toolkit to avoid error "error: libdevice not found at ./libdevice.10.bc". Ref: #2201

@singhniraj08
Copy link
Author

@zhlnhn, I have created this PR to address the issue #2201. Please review and approve. Thanks.

@MartijnVanbiervliet
Copy link

Though installing the entire cuda-toolkit solves the issue in #2201, it increases the image size by up to 4GB. I have tried alternatives and it seems sufficient to install the cuda-compiler metapackage.

MartijnVanbiervliet
MartijnVanbiervliet reviewed Feb 20, 2024
View reviewed changes
tensorflow_serving/tools/docker/Dockerfile.gpu Outdated
@@ -60,6 +60,8 @@ RUN apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/machi
&& apt-get clean && \
rm -rf /var/lib/apt/lists/*;

RUN apt-get update && apt-get install -y cuda-toolkit-11-8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be conscious about the size of the container image, I would recommend installing this as part of the RUN command at line 34 to prevent additional Docker layers.

@singhniraj08
Copy link
Author

@MartijnVanbiervliet, Hi, I have moved the cuda-toolkit installation to line 34 as suggested. I tried to build the image with latest cuda-toolkit-12-3, but the image size increased further so had to stick with cuda-toolkit-11-8. Please review.
Thank you!

@gbaned
Copy link
Contributor

gbaned commented Mar 6, 2024

Hi @singhniraj08 Can you please sign CLA? Thank you!

@general-adhoc
Copy link

Is there any update on the merge progress of this?

@gbaned
Copy link
Contributor

gbaned commented Mar 18, 2024

Hi @MartijnVanbiervliet Can you please sign CLA? Thank you!

@MartijnVanbiervliet
Copy link

@gbaned I have signed CLA. Please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnVanbiervliet MartijnVanbiervliet MartijnVanbiervliet left review comments

@zhlnhn zhlnhn Awaiting requested review from zhlnhn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singhniraj08 @MartijnVanbiervliet @gbaned @general-adhoc