Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_cuda impacts all the cc targets #104

Open
xhuaoe opened this issue May 1, 2022 · 1 comment
Open

rules_cuda impacts all the cc targets #104

xhuaoe opened this issue May 1, 2022 · 1 comment

Comments

@xhuaoe
Copy link

xhuaoe commented May 1, 2022

Hi,

I am using bazel and there's cuda code and c++ code in the repo. IIUC rules_cuda patches rules_cc and changes some settings. Such changes apply to all the cc targets, not only cuda targets after we run rules_cc_toolchains().

Is it possible to limit the impact only to cuda_library without touching cc targets? I am currently encountering an issue of --features=external_include_paths not working since it's missing in the cc toolchain patched by rules_cuda. More generally, it would be great if rules_cc can be purely some implementation detail of rules_cuda / cuda_library without anything "leaking" outside cuda targets.

@cloudhan
Copy link

Then you need my pure starlark implementation https://github.com/cloudhan/rules_cuda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants