Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Convention] Replace Tf with TF in CRD #328

Closed
DjangoPeng opened this issue Jan 19, 2018 · 2 comments
Closed

[Convention] Replace Tf with TF in CRD #328

DjangoPeng opened this issue Jan 19, 2018 · 2 comments

Comments

@DjangoPeng
Copy link
Member

DjangoPeng commented Jan 19, 2018 •
edited
Loading

I noticed that there is a discussion of CRD name：TfJob vs TFJob

Actually, we prefer TFJob cause TF is an abbreviation of TensorFlow. According to the Golang and Kubernetes convention, TFJob is better as well.

So we'd better replace Tf with TF in CRD and some related function name. Ref: #283 (comment)

/cc @jlewi @gaocegege @ScorpioCPH
@DjangoPeng DjangoPeng mentioned this issue Jan 19, 2018
Closed
6 tasks
@ScorpioCPH
Copy link
Member

+1 for TFJob, PR is coming :)

@ScorpioCPH ScorpioCPH mentioned this issue Jan 19, 2018
Merged
@jlewi
Copy link
Contributor

jlewi commented Jan 23, 2018

We announced this on Slack on January 20 7am Saturday and said we'd close voting by EOD Monday.
Since no one's chimed I think we can go with TFJob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @ScorpioCPH @DjangoPeng