Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Detection #110

Open
TimSchmeier opened this issue Sep 15, 2022 · 6 comments
Open

Link Detection #110

TimSchmeier opened this issue Sep 15, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@TimSchmeier
Copy link

TimSchmeier commented Sep 15, 2022

Hi,

Sorry if I've missed it but I'm looking for examples or docs around building a gnn for link detection. The docs that I've found center around node / context classification. Is link classification supported? Are there examples available for this sort of task using tf-gnn yet?

Thanks,
Tim

@arnoegw
Copy link
Collaborator

arnoegw commented Sep 16, 2022

Hi @TimSchmeier , thanks for reaching out!

TF-GNN does support building GNNs suitable for link prediction/detection/classification. For a demonstration of an advanced model on a toy dataset, please see our shortest-path colab. TF-GNN's modeling guide talks about using edge states in addition to just node states.

That said, the end-to-end examples shipped with TF-GNN initially focus on node classification, and the graph sampler tool caters to that.

Let's keep this open as a feature request for a link prediction demo on a serious dataset. (No promises of timeline.)

@arnoegw arnoegw added the enhancement New feature or request label Sep 16, 2022
@TimSchmeier
Copy link
Author

Sounds good, I'll take a look. If I can figure it out I'll open a PR for a notebook.

@mach-12
Copy link

mach-12 commented Dec 12, 2023

@arnoegw
Is this enchancemnet still open? Would be willing to contribute.

@aferludin
Copy link
Contributor

Hi @mach-12

We have limited support for link prediction in 1.0 as

  • experimental sampling: experimental/sampler/link_samplers.py to create sampling model and in tfgnn_sampler tool, see tensorflow_gnn/sampler/sampling_spec.proto:SymmetricLinkSeedOp. Documentation is coming in 1.1.

  • runner: tensorflow_gnn/runner/tasks/link_prediction.py

@janpfeifer
Copy link
Contributor

hi @mach-12 ,

I just wanted to mention that we love to see contributions of different model types that use TF-GNN. But we hesitate in incorporating them to the main repo, because of maintenance concerns.

If you are interested in doing a link prediction (detection) GNN model, I was going to suggest to create your own repository, and we'll add in our home (README.md file) a section on contributed models and link to it, with a description line.

Contributed models that become very popular / asked for, we could move to the main repo, attributing clearly proper credit to the author(s).

cheers

@mach-12
Copy link

mach-12 commented Dec 21, 2023

Thank you. Going to go along with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants