evidence: fix bug with hashes #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
alexanderbez,
ebuchman,
tessr and
tychoish
as code owners
cmwaters
changed the title
alexanderbez
approved these changes
Apr 20, 2021
cmwaters
commented
Apr 21, 2021
Comment on lines
+1031
to
+1033
| // NOTE: Sometimes we use the bytes of the proto form as a hash. This means that we need to | ||
| // be consistent with cached data | ||
| vp.TotalVotingPower = 0 |
There was a problem hiding this comment.
Can you confirm that this doesn't break proto
cmwaters
added
the
S:backport-to-v0.34.x
Codecov Report
@@ Coverage Diff @@
## master #6375 +/- ##
==========================================
+ Coverage 60.78% 60.80% +0.01%
==========================================
Files 282 282
Lines 26910 26868 -42
==========================================
- Hits 16358 16336 -22
+ Misses 8839 8824 -15
+ Partials 1713 1708 -5
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
(cherry picked from commit 5bafedf) # Conflicts: # CHANGELOG_PENDING.md # evidence/pool.go # evidence/pool_test.go # evidence/verify.go # evidence/verify_test.go # p2p/shim.go # test/e2e/networks/ci.toml # test/e2e/pkg/testnet.go # test/e2e/runner/evidence.go
cmwaters
pushed a commit
that referenced
this pull request
Apr 22, 2021
4 tasks
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking solution to #6342 where the hashes remain the same.
Specifically, I have removed
fastCheckand modified theCheckEvidencefunction so that the bytes of the evidence are not modified.I have also added some more tests on top of this
Closes: #6326
Closes: #6312
Addresses: #5942