-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evidence: json tags for DuplicateVoteEvidence #4959
Conversation
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
+ Coverage 63.35% 63.38% +0.03%
==========================================
Files 189 189
Lines 19583 19584 +1
==========================================
+ Hits 12407 12414 +7
+ Misses 6189 6184 -5
+ Partials 987 986 -1
|
VoteA *Vote | ||
VoteB *Vote | ||
VoteA *Vote `json:"vote_a"` | ||
VoteB *Vote `json:"vote_b"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks like we need also need to remove the pubkey field in the rust version too: https://github.com/informalsystems/tendermint-rs/pull/242/files#r417475910
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Add json tags to duplicate evidence
Closes: #4958