Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide about putting claim in its own repo #899

Closed
lumtis opened this issue Jul 20, 2022 · 4 comments
Closed

Decide about putting claim in its own repo #899

lumtis opened this issue Jul 20, 2022 · 4 comments
Assignees
Labels
claim Related to claim module

Comments

@lumtis
Copy link
Contributor

lumtis commented Jul 20, 2022

claim module is aimed to be imported by other projects.
It may make sense to move the module to its own repo with its own docs to emphasize its independency.

Solutions:

  • Keep under spn
    • Drawback: doesn't emphasize module independency
  • Minimal repository:
    • Only the module repository with proto definition with no environment (no app, no simulation tests)
    • Drawback: no simulation tests integrated
  • Chain with module imported
    • Regular chain with app dir, simulation test, etc...
    • Drawback: may need to reimplement testutils etc...
  • Repository for all independent modules we may have
    • Repo named like modules that integrates modules aimed to be imported by other projects as well
    • Might be the case with mint: Making mint module universal #895
    • Drawback: emphasize less on the module independency
@lumtis lumtis added the claim Related to claim module label Jul 20, 2022
@lumtis
Copy link
Contributor Author

lumtis commented Jul 26, 2022

Let's wait upgrading everything to 0.46 before doing claim migration #906

@lumtis lumtis self-assigned this Jul 26, 2022
@lumtis
Copy link
Contributor Author

lumtis commented Jul 26, 2022

As we will work in several different independent modules. The idea would be to have ignite/modules with a test application inside for CI and test purposes

@tbruyelle
Copy link
Contributor

The idea would be to have ignite/modules with a test application inside for CI and test purposes

Actually I was wondering if we can avoid integration test with custom modules. Indeed we can mock all their interactions with other modules thanks to the interfaces declared in expected_keepers.go, the other interaction I'm aware of is the KVStore, but I don't know if we can mock it.

@lumtis
Copy link
Contributor Author

lumtis commented Jul 26, 2022

Maybe related to your point? #807

We use for now a package testutils/keeper for all tests where all keepers are initialized, but the idea in the future is to define mocks for every module so that tests for a single module can be isolated.

I think there is some room to define a generic test framework for SDK modules that could be located in ignite/modules and spn would use this framework

For the initial point, ignite/modules will also need a sample app to perform simulation tests with the modules

@lumtis lumtis closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claim Related to claim module
Projects
None yet
Development

No branches or pull requests

2 participants