Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying policies to minimize panic #224

Closed
4 tasks
dongsam opened this issue Nov 10, 2021 · 0 comments · Fixed by #230
Closed
4 tasks

Applying policies to minimize panic #224

dongsam opened this issue Nov 10, 2021 · 0 comments · Fixed by #230
Assignees

Comments

@dongsam
Copy link
Contributor

dongsam commented Nov 10, 2021

Summary

Due to the nature of the blockchain, if there is a panic, the chain will stop. As such, panic should only be for non-recoverable errors, and if it is reversible like msg_server level or can fall into an exceptional case due to other module dependencies, I think it is better to process and errors with revert rather than panic.

It was also mentioned in the Cosmos-cash team's review, and all panic and error handling needs to be reconsidered.

Tasks

  • DecreaseTotalStakings
  • DecreaseOutstandingRewards
  • ...

References


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dongsam dongsam self-assigned this Nov 10, 2021
@dongsam dongsam added this to the Farming F1 v1.0 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants