Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: epoch is being increased multiple times when there is two or more plans sharing same staking coin denom #126

Closed
hallazzang opened this issue Sep 17, 2021 · 2 comments · Fixed by #128 or #143
Closed

bug: epoch is being increased multiple times when there is two or more plans sharing same staking coin denom #126

hallazzang opened this issue Sep 17, 2021 · 2 comments · Fixed by #128 or #143
Assignees
@hallazzang
Labels
bug Something isn't working
Milestone
Farming F1 v1.0

Comments

@hallazzang
Copy link
Contributor

Description

For each AllocateRewards() call, the epoch of a staking coin denom should be increased by only 1.
But currently if there are two or more plans sharing same staking coin denom for their staking coin weights,
the epoch is being increased more than 1 times.

Version

master(60a8fd7)
@hallazzang hallazzang added the bug Something isn't working label Sep 17, 2021
@hallazzang hallazzang added this to the Farming F1 MVP milestone Sep 17, 2021
@hallazzang hallazzang self-assigned this Sep 17, 2021
@hallazzang hallazzang mentioned this issue Sep 17, 2021
Merged
9 tasks
@dongsam dongsam linked a pull request Sep 17, 2021 that will close this issue
fix: increase epoch only once for each AllocateRewards #128
Merged
9 tasks
@dongsam
Copy link
Contributor

dongsam commented Sep 17, 2021

Could you add a test code to validate this case does not occur anymore?
I heard you the test code would be included on #119 right?

@hallazzang
Copy link
Contributor Author

@dongsam Yes I'm adding tests to test if this issue has been resolved

@hallazzang hallazzang mentioned this issue Sep 28, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
bug Something isn't working
Projects
None yet
Milestone
Farming F1 v1.0
2 participants
@dongsam @hallazzang