Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good first issue] Cover adjuststack instruction with tests #74

Open
nvasilevski opened this issue Oct 27, 2021 · 0 comments
Open

[Good first issue] Cover adjuststack instruction with tests #74

nvasilevski opened this issue Oct 27, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@nvasilevski
Copy link
Collaborator

It's a good issue to start contributing!
adjuststack has been implemented but we are missing a test:

def handle_adjuststack n
n.times { @temp_stack.pop }
end

def test_adjuststack
skip "adjuststack has been implemented. Please add a test."
end

Here is an example of the code that supposed to generate adjuststack instruction:
https://github.com/ruby/ruby/blob/9eae8cdefba61e9e51feb30a4b98525593169666/bootstraptest/test_insns.rb#L133

@nvasilevski nvasilevski added the good first issue Good for newcomers label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant