Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any interest in dropping dependency on "dockerize" #1703

Open
jonjohnsonjr opened this issue Oct 23, 2023 · 1 comment
Open

Any interest in dropping dependency on "dockerize" #1703

jonjohnsonjr opened this issue Oct 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jonjohnsonjr
Copy link

Is your feature request related to a problem? Please describe.

I noticed that start-server-ui.sh uses dockerize for templating this file.

This isn't a problem per se, but it does add ~6MB to your image size to do some fairly mundane template rendering.

Describe the solution you'd like

Looking at the template, I see that it uses default and split functions, which are not particularly complicated. This seems like something that could be implemented in the fs_config_loader directly rather than via packaging an additional binary in the docker image.

Would there be any interest in a PR that does something like this? Either through a separate subcommand of ui-server or via a flag?

Describe alternatives you've considered

Do nothing.

Additional context

@jonjohnsonjr jonjohnsonjr added the enhancement New feature or request label Oct 23, 2023
@robholland
Copy link
Contributor

We are currently migrating the templating into the temporal binary to avoid the dep, and more importantly, to avoid having to write the config out to the container filesystem. Would welcome a similar change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants