You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This isn't a problem per se, but it does add ~6MB to your image size to do some fairly mundane template rendering.
Describe the solution you'd like
Looking at the template, I see that it uses default and split functions, which are not particularly complicated. This seems like something that could be implemented in the fs_config_loader directly rather than via packaging an additional binary in the docker image.
Would there be any interest in a PR that does something like this? Either through a separate subcommand of ui-server or via a flag?
Describe alternatives you've considered
Do nothing.
Additional context
The text was updated successfully, but these errors were encountered:
We are currently migrating the templating into the temporal binary to avoid the dep, and more importantly, to avoid having to write the config out to the container filesystem. Would welcome a similar change here.
Is your feature request related to a problem? Please describe.
I noticed that start-server-ui.sh uses
dockerize
for templating this file.This isn't a problem per se, but it does add ~6MB to your image size to do some fairly mundane template rendering.
Describe the solution you'd like
Looking at the template, I see that it uses
default
andsplit
functions, which are not particularly complicated. This seems like something that could be implemented in the fs_config_loader directly rather than via packaging an additional binary in the docker image.Would there be any interest in a PR that does something like this? Either through a separate subcommand of
ui-server
or via a flag?Describe alternatives you've considered
Do nothing.
Additional context
The text was updated successfully, but these errors were encountered: