Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where setting TEMPORAL_CLOUD_API_KEY interferes with unit tests #399

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix bug where setting TEMPORAL_CLOUD_API_KEY interferes with unit tests #399

merged 1 commit into from
Oct 18, 2024

Conversation

mattkim
Copy link
Member

@mattkim mattkim commented Oct 17, 2024

What was changed

fix bug where setting TEMPORAL_CLOUD_API_KEY interferes with unit tests

Why?

#349

@mattkim mattkim requested a review from a team as a code owner October 17, 2024 23:43
@mattkim mattkim enabled auto-merge (squash) October 18, 2024 00:14
shakeelrao
shakeelrao approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@shakeelrao shakeelrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, but is it possible to change the test to not rely on env variables to begin with?

@mattkim mattkim merged commit ed9abc1 into main Oct 18, 2024
4 checks passed
@mattkim mattkim deleted the mattkim/fix-connection-test-bug branch October 18, 2024 00:31
@briankassouf briankassouf mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakeelrao shakeelrao shakeelrao approved these changes

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkim @briankassouf @shakeelrao