Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceWorkflowHistoryIterator should eagerly request the next page #1707

Open
Tracked by #778
Spikhalskiy opened this issue Mar 21, 2023 · 1 comment
Open
Tracked by #778

ServiceWorkflowHistoryIterator should eagerly request the next page #1707

Spikhalskiy opened this issue Mar 21, 2023 · 1 comment
Labels
enhancement User experience

Comments

@Spikhalskiy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some users experience issues with replays of long workflow histories.

Describe the solution you'd like
While this process will always inherently has O(n) complexity and there is not much that we can do with that, there is one low hanging fruit to improve it.
Currently ServiceWorkflowHistoryIterator requests the next page only when the worker is already blocked and finished processing the previous page. It may be optimized by requesting the next page immediately.

Additional context

See io.temporal.client.EagerPaginator and it's implementations where such an approach and logic are already implemented.
@Spikhalskiy Spikhalskiy added the enhancement User experience label Mar 21, 2023
@Spikhalskiy Spikhalskiy mentioned this issue Mar 22, 2023
Open
13 tasks
@Spikhalskiy
Copy link
Contributor Author

Related #1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Spikhalskiy